fix EmbeddableDisplay

[jbrea]

Fixes #2619

[github-actions]

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/jbrea/Pluto.jl", rev="fix_more")
julia> using Pluto

[disberd]

I just tried out this pull request but unfortunately it does not seem to fix #2619 for logs. more inside @info does not seem to work in any situation (with or without embed_display and with or without @htl).
This was expected as @Pangoraw pointed out in his comment

[jbrea]

Ah, yes, indeed. I only looked at my original bug report. This is the only functionality I need for the class starting mid September.
If I find the time I can try to have a look at @info and friends.

[jbrea]

This takes too much time for me, sorry. I fixed one issue, which was that all logs had a hand-written cell-id "adsf".
But now I would have to mess with set_output! in Run.jl and I don't yet really see the best solution. Maybe it would be best to treat logs as special published_outputs? Or copy the mechanism of published_outputs to logs? No clue, and I don't have the time to figure it out and fix this this now.

[disberd]

Yeah don't worry I'll just open a new issue for logs.
I think you can also just revert your latest commit so that you only fix the lingering error in embed display.
That way it's really just a single line fixing a specific and clearly identified issue. Hopefully that way it will be much faster to get merged :)

[jbrea]

OK, thanks.

[disberd]

Tagging @Pangoraw for review/merge. This is important to get merged before the next release as embed_display will break since #2608 has been merged (and missed changing the code of show in this fix)

[Pangoraw]

Thanks @jbrea and @disberd! I added a test which could have detected the problem and opened a new issue to track the problem in logs: #2633.