-
Notifications
You must be signed in to change notification settings - Fork 136
Conversation
I think it would be better to make these part of the CI process. I'm currently trying to break free of CircleCI on the foniod/build-images#1 PR, and use that to build the base builder images for the 3 main distros. As soon as that works, we should move these Dockerfiles over, and extend the CI here with these builds. What do you think? |
I am not familiar with CircleCI yet, so I have a question about it. |
In theory this exists, but I could never get it working reliably. It comes with a lot of limitations, and I don't think we can actually use their local build tool for RedBPF. CircleCI CLI has some docs on usage if you would like to try regardless. My usual workflow involves triggering an actual CI run in the cloud, and working through it on a branch. Not the most fun, but I think you have a lot of scaffolding to play with at this stage. Do let me know if you need help, though, and I can probably take a look! |
2855bc3
to
66bd707
Compare
@rsdy |
I think it's a good direction! GitHub Actions also looks like a better long-term option than CircleCI, so happy to go down this route! |
.github/workflows/build-test.yml
Outdated
docker run --privileged \ | ||
-v /sys/kernel/debug:/sys/kernel/debug:rw \ | ||
-v /lib/modules:/lib/modules:ro \ | ||
-v /usr/src:/usr/src:ro \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to override the containers' kernels with whatever we get from GitHub? I feel like this can potentially make it harder to build for a larger range of kernels.
Going forward, I think it might be helpful to think about building for many different kernel versions to see what we can/cannot support.
Just a suggestion, though, I think it's not a straightforward thing so will be a process to get there.
66bd707
to
0c1b686
Compare
I fixed it not to mount volumes of kernel headers and changed to specify |
Signed-off-by: Junyeong Jeong <[email protected]>
0c1b686
to
7be64fd
Compare
I fixed workflow to make kernel version not to be hard coded because base image from |
I could not add build test for ubuntu-18.04.
And the version of included kernel header is 4.15.0-142-generic. It is too old version. |
If you remove the CIrcleCI builds, I can merge this and move on from here. I know how to fix the LLVM_SYS issues, but we also need to upgrade to LLVM 12 as the latest Rust compiler already uses that. |
CircleCI config is deleted. |
Signed-off-by: Junyeong Jeong <[email protected]>
3a6093c
to
bf59b21
Compare
I come up with this PR when I ran into the build failure of #131. Because I
tried building RedBPF only under my Pop OS, I could not recognize the build failures
derived from other distros.
And also by
Dockerfile-alpine-20210212
this PR suggests the solution of #130.