Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Added a transparent textarea option #91

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Conversation

LewHgh
Copy link
Contributor

@LewHgh LewHgh commented Aug 15, 2018

This pull request is to add a transparent textarea option on forms as shown below:
image

@y0hami y0hami added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Aug 15, 2018
@y0hami y0hami requested review from ColinFrick and prudho August 15, 2018 06:09
@ColinFrick
Copy link
Member

Great addition!
Quick question: Do we have to handle the field error state for this?

Currently it would look like this:
grafik

@y0hami
Copy link
Member

y0hami commented Aug 15, 2018

Transparent inputs currently work like that but maybe we should change them to looks something like this:

textarea:
image
image

input:
image
image

@ColinFrick
Copy link
Member

@hammy2899 We could merge this and open a new issue for the error state for both input and textarea.

@y0hami
Copy link
Member

y0hami commented Aug 15, 2018

@ColinFrick Yep I agree

@y0hami y0hami requested review from ColinFrick and y0hami and removed request for prudho August 15, 2018 09:54
@y0hami y0hami added this to the 2.5 milestone Aug 15, 2018
@y0hami y0hami merged commit 0386f82 into fomantic:beta Aug 15, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Aug 15, 2018
@y0hami y0hami added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants