Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements dropdown different sizes (standalone and in forms) #57

Merged
merged 3 commits into from
Aug 28, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Jul 6, 2018

This PR allow different sizes for dropdowns. It will need a lot of tests before merging it !

Closed Issues

Semantic-Org/Semantic-UI#5154

@prudho prudho added type/feat Any feature requests or improvements lang/css Anything involving CSS type/discussion Anything which is up for discussion state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Jul 6, 2018
@prudho prudho added this to the 2.5 milestone Jul 6, 2018
@prudho
Copy link
Contributor Author

prudho commented Jul 27, 2018

I have added CSS for menus dropdowns and buttons groups dropdowns.

Here is a gist I use to tests many dropdown cases: https://gist.github.com/prudho/5a4af7e96a5abf6d08df6b3a0fb7aec4

There's some little tweaks to provide yet:

  • images aren't exactly vertical aligned to text.
  • labels aren't exactly vertical aligned to text.

But aside this little issues, this code should now me mergeable 😎

@prudho prudho requested review from ColinFrick and y0hami August 27, 2018 07:09
@prudho prudho added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Aug 27, 2018
@y0hami y0hami merged commit b52fb5d into fomantic:beta Aug 28, 2018
@prudho prudho deleted the multisize-dropdown branch August 28, 2018 07:31
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Sep 18, 2018
@brendon
Copy link

brendon commented Sep 9, 2019

With this change, if one has a button driven dropdown (where the button is also the dropdown container), and one sizes the button as tiny for example, the dropdown menu contents will also be font-sized tiny which in my case was unexpected. Previously, the button would be sized tiny, but the menu would be normal sized.

Ideally there should be a way to override the size of the dropdown if the driving container's size has been set to something else.

a.k.a. just because we want the button to be tiny, doesn't mean we want the dropdown menu to also be tiny.

@prudho
Copy link
Contributor Author

prudho commented Sep 11, 2019

Could you provide a JSFiddle please ? Or open a new issue with an example ? Thanks

@brendon
Copy link

brendon commented Sep 11, 2019

Sorry, here are the fiddles. Let me know if you'd still rather me open a new issue:

Fomantic-UI: https://jsfiddle.net/4ytcfw8b/
Semantic-UI: https://jsfiddle.net/gpakxocL/4/

Further investigation shows me that more complex menu's break down under SUI when using tiny on the button but I didn't have a very complex menu :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/discussion Anything which is up for discussion type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants