[Tab] Allow centered tab menu #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudho
added
type/feat
y0hami
previously approved these changes
Jul 2, 2018
y0hami
added
Can Merge
and removed
state/awaiting-reviews
ColinFrick
added
the
state/on-hold
y0hami
added
state/awaiting-reviews
This corresponds to the right modifier Caveat: Does not display a border left or right, because :after definition is used for pointing menu Closes Semantic-Org/Semantic-UI#5589
ColinFrick
removed
the
state/on-hold
y0hami
approved these changes
Aug 9, 2018
ColinFrick
approved these changes
Aug 10, 2018
|
shouldn't it be "centered menu" or "center aligned menu", not "center menu" ? no sample or doc. |
|
@romaninsh it follows the same syntax as the alignment modifiers for the menu (left / right) Docs will be updated before the release. |
y0hami
removed
the
state/awaiting-reviews
y0hami
added
state/has-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow tab menu to be centered. Also works with the secondary style. Closes Semantic-Org/Semantic-UI#5589.
Thanks @franckpopchef for the implementation idea !