fix(deps): downgrade ordered-read-streams #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns out the latest version of ordered-read-streams, 2.0.0, does not always order the files as they were given.
Looks like the issue is inside the new used streamx lib. It seems the given order is modified internally by the end of the file read, so larger files are merged at the end rather than the desired position.
For example the large emoji.css was always set to the end of the order although the order of that file was given much earlier in the stream array.
Reverting back to to v 1.0.1 fixes that (as it does not use streamx, but readable-stream instead of streamx)