Skip to content

Commit

Permalink
fix(popup): detailed rtl check
Browse files Browse the repository at this point in the history
I added more detailed check for rtl. Currently only the module is checked. However, if body or the surrounding context would be defined as rtl then the module itself is also displayed as rtl, so this PR enhances the check (i already did the same inside the sidebar PR and modal PR)
  • Loading branch information
lubber-de authored Aug 24, 2022
1 parent baa8544 commit 19b7d18
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/definitions/modules/popup.js
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,7 @@ $.fn.popup = function(parameters) {
return !module.is.visible();
},
rtl: function () {
return $module.attr('dir') === 'rtl' || $module.css('direction') === 'rtl';
return $module.attr('dir') === 'rtl' || $module.css('direction') === 'rtl' || $body.attr('dir') === 'rtl' || $body.css('direction') === 'rtl' || $context.attr('dir') === 'rtl' || $context.css('direction') === 'rtl';
}
},

Expand Down

0 comments on commit 19b7d18

Please sign in to comment.