fix(notifier): disable colorcolumn by default
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
makes sense. Thanks! |
folke
pushed a commit
that referenced
this pull request
Nov 14, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.0](v1.2.0...v2.0.0) (2024-11-14) ### ⚠ BREAKING CHANGES * **config:** plugins are no longer enabled by default. Pass any options, or set `enabled = true`. ### Features * **config:** plugins are no longer enabled by default. Pass any options, or set `enabled = true`. ([797708b](797708b)) * **health:** added health checks to plugins ([1c4c748](1c4c748)) * **terminal:** added `Snacks.terminal.colorize()` to replace ansi codes by colors ([519b684](519b684)) ### Bug Fixes * **lazygit:** not needed to use deprecated fallback for set_hl ([14f076e](14f076e)) * **notifier:** disable `colorcolumn` by default ([#66](#66)) ([7627b81](7627b81)) * **statuscolumn:** ensure Snacks exists when loading before plugin loaded ([97e0e1e](97e0e1e)) * **terminal:** properly deal with args in `vim.o.shell`. Fixes [#69](#69) ([2ccb70f](2ccb70f)) * **win:** take border into account for window position ([#64](#64)) ([f0e47fd](f0e47fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
colorcolumnshould be disabled by default, since in most cases, the user will not want to have them displayed in a notification.Screenshots
before:
after:
