bug: root_dir broken, always gets set when .neoconf.json is present

[mehalter]

Did you check docs and existing issues?

• I have read all the neoconf.nvim docs
• I have searched the existing issues of neoconf.nvim
• I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.10.0 (github release)

Operating system/version

Arch Linux

Describe the bug

I noticed recently some of my language servers that shouldn't be starting are starting and not respecting the root_dir that they have defined either the defaults provided by lspconfig nor the ones I specify in my own configuration. This lead me down one crazy rabbit hole of source code digging until I found that Neoconf is actually overriding root_dir function in a way that makes it always set the root directory if a neoconf.json file is set. This really messes up language servers that require configuration files to function and so the root_dir is quite strict to only enable when those configuration files are present.

Steps To Reproduce

Requires: lua language server in path, I picked one I figured you probably have, feel free to adjust the repro.lua accordingly

0. rm -rf .repro, make sure it's a clean environment
1. nvim -u repro.lua repro.lua, run neovim and open repro.lua
2. :LspInfo, see that 0 clients are attached to the buffer
3. quit neovim
4. touch .neoconf.json, make an empty Neoconf configuration file
5. nvim -u repro.lua repro.lua, run neovim and open repro.lua
6. :LspInfo, see that 1 client is attached to the buffer

Expected Behavior

I would expect that my language servers respect the root_dir that are set for them. A lot of language servers have blanket root directories such as .git, but this is not all of them. Many language servers require the presence of configuration files and therefore having a blanket root directory is bad. Also, even if there is a default blanket type of root directory, if I manually set root directory configuration, it should be respected fully. It seems like with the current implementation in Neoconf, there is no way to remove behavior at all.

Repro

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    "neovim/nvim-lspconfig",
    "folke/neoconf.nvim",
  },
})

require("neoconf").setup({})

-- set up a language server with no single file support
-- and a `root_dir` function that would never activate it
require("lspconfig").lua_ls.setup({
  root_dir = function()
    return nil -- effectively _never_ set a root directory
  end,
  single_file_support = false,
})

[folke]

I personally don't use neoconf anymore, but the only recent change I made related to what you describe should now be reverted in that new commit.

Can you confirm this is now working as expected again?

[mehalter]

Yup that seems to work again! Thanks so much @folke !