TTFFont.parse should call *Table constructors with explicit @tag param #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bug appears when the library is bundled with browserify+uglify (or any other minify lib); by default uglify task mangle function names so in the
Table
constructor code like@constructor.name
would return some'b'
or'c'
which leads to errors hard to debug (since the problem appears only with the minified versions; like this one bpampuch/pdfmake#18 or this one bpampuch/pdfmake#60 )Is it good or bad to rely on function names at runtime (especially if we are targeting the browser)?
See this interesting discussion pugjs/pug#298 (
uglify
vsjade
)