[UIPQB-145] Display raw booleans in nested table #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncovercash
requested review from
SergeYvas,
bvsharp,
kjain110 and
mweaver-ebsco
|
SergeYvas
approved these changes
Oct 25, 2024
| import PropTypes from 'prop-types'; | ||
| import css from './DynamicTable.css'; | ||
|
|
||
| const columnStyle = { width: '180px', minWidth: '180px' }; | ||
|
|
||
| function getCellValue(row, property) { | ||
| // typeof check to ensure we don't try to display null/undefined as a booleans | ||
| if (property.dataType.dataType === 'booleanType' && typeof row[property.property] === 'boolean') { |
There was a problem hiding this comment.
I suggest using isBoolean(value) from Lodash for the boolean check and DATA_TYPES.BooleanType constant instead of 'booleanType'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.