test some nodey things #1624
Closed
test some nodey things #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
I'm so confused. Log output in this PR shows we are indeed on NodeJS 12, but the timing of the failed builds this morning, as mentioned in the description, lines up so nicely with the bug reports in node, and the timing of the successful build later without any changes lines up so nicely with the PR in node, it feels like that must be implicated somehow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output node version in GA workflow to help evaluate build errors.
Errors in https://github.com/folio-org/ui-inventory/runs/5495824257?check_suite_focus=true imply GA is running NodeJS v17, which is causing a yarn v1 regression: nodejs/node#42136 (comment)