Skip to content

Commit

Permalink
STRWEB-108 Favicons not injected into html template. (#137)
Browse files Browse the repository at this point in the history
* remove usage of speed measurer webpack plugin

* log changes
  • Loading branch information
JohnC-80 authored Mar 5, 2024
1 parent 869d08a commit e5da675
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Add postcss-plugin for relative color syntax support for Firefox. Refs STRWEB-103.
* Lock `favicons` to `7.1.4` due to build failures. Refs STRWEB-105.
* Update `typescript` from `^4.2.4` to `^5.3.3`. Refs STRWEB-104.
* Resolve issue with favicon referencing by removing `speed-measurer-webpack-plugin` and its wrapping of other webpack plugins. Refs STRWEB-108.

## [5.0.0](https://github.com/folio-org/stripes-webpack/tree/v5.0.0) (2023-10-11)
[Full Changelog](https://github.com/folio-org/stripes-webpack/compare/v4.2.0...v5.0.0)
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
"semver": "^7.1.3",
"serialize-javascript": "^5.0.0",
"source-map-loader": "^4.0.0",
"speed-measure-webpack-plugin": "^1.5.0",
"stream-browserify": "^3.0.0",
"style-loader": "^3.3.0",
"tapable": "^1.0.0",
Expand Down
7 changes: 2 additions & 5 deletions webpack.config.cli.prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
const webpack = require('webpack');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const { EsbuildPlugin } = require('esbuild-loader');
const SpeedMeasurePlugin = require('speed-measure-webpack-plugin');
const buildBaseConfig = require('./webpack.config.base');

const cli = require('./webpack.config.cli');
Expand All @@ -27,7 +26,6 @@ const buildConfig = (stripesConfig) => {

const transpiledModules = getTranspiledModules(allModulePaths);
const transpiledModulesRegex = new RegExp(transpiledModules.join('|'));
const smp = new SpeedMeasurePlugin();

prodConfig.plugins = prodConfig.plugins.concat([
new webpack.ProvidePlugin({
Expand Down Expand Up @@ -61,12 +59,11 @@ const buildConfig = (stripesConfig) => {

prodConfig.module.rules.push(esbuildLoaderRule(allModulePaths));

const webpackConfig = smp.wrap({ plugins: prodConfig.plugins });
webpackConfig.plugins.push(
prodConfig.plugins.push(
new MiniCssExtractPlugin({ filename: 'style.[contenthash].css' })
);

return { ...prodConfig, ...webpackConfig };
return prodConfig;
};

module.exports = buildConfig;

0 comments on commit e5da675

Please sign in to comment.