STCOR-729 update test deps for react v18 #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed a few test-related deps in #1324. Refs STCOR-729
|
Kudos, SonarCloud Quality Gate passed!
|
vashjs
approved these changes
Jul 27, 2023
| await waitFor(() => { | ||
| return !result.current.isLoading; | ||
| if (result.current.isLoading) { |
There was a problem hiding this comment.
Maybe it makes sense move this part to separate function? I see it used in 4 places
if (result.current.isLoading) {
throw new Error('Kaboom');
}
There was a problem hiding this comment.
🤷 I see your point, but there's not a lot going on here. I can imagine this also being written as
result.current.isLoading && throw new Error('Kaboom');
in which case we'd be replacing one line with ... one other line. It's a good thing to keep in mind though.
JohnC-80
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed a few test-related deps in #1324. Additionally, convert from local deps/config to importing from jest-config-stripes.
Refs STCOR-729