-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STCOR-551 configure karma for v6 compatibility #1081
Conversation
There are some overlapping things going on here. * `stripes-webpack` supports the new JSX transform that means we shouldn't have to `import React ...` any longer, but BigTest tests fail without it when using `karma` `v4` (from `stripes-cli` `v1.2`). * when using `karma` `v6` (from `stripes-cli` `v1.3`), the karma config directives `files` and `preprocessors` cause test files not be found at all. Bumping the `stripes-cli` dep (so we get `karma` `v6`) and cleaning up `karma.config.js` (so it is `v6` compatible, and more aligned with configs in other repos) allows tests to run as they always did. Phew. Refs STCOR-551
BigTest Unit Test Statistics 1 files ±0 1 suites ±0 11s ⏱️ ±0s Results for commit a9a1453. ± Comparison against base commit a9a1453. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
yarn run v1.22.5 $ eslint . && stylelint "src/**/*.css" |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Thanks for toiling in the mines. ⛏️
There are some overlapping things going on here.
stripes-webpack
supports the new JSX transform that means weshouldn't have to
import React ...
any longer, but BigTest testsfail without it when using
karma
v4
(fromstripes-cli
v1.2
).karma
v6
(fromstripes-cli
v1.3
), the karma configdirectives
files
andpreprocessors
cause test files not be foundat all.
Bumping the
stripes-cli
dep (so we getkarma
v6
) and cleaning upkarma.config.js
(so it isv6
compatible, and more aligned withconfigs in other repos) allows tests to run as they always did. Phew.
Refs STCOR-551