Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IconButton test for react-router 4.3 #417

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Update IconButton test for react-router 4.3 #417

merged 1 commit into from
Jun 7, 2018

Conversation

cherewaty
Copy link
Collaborator

Purpose

react-router 4.3.x introduced a change to the way Links construct: remix-run/react-router#5489

Approach

Use the StaticRouter to test instead of HashRouter.

@cherewaty cherewaty requested a review from JohnC-80 June 7, 2018 18:19
@cherewaty
Copy link
Collaborator Author

Successfully tested ui-eholdings on react-router-dom 4.3.1 with no issues 👌

@cherewaty cherewaty merged commit 5b8c5e3 into folio-org:master Jun 7, 2018
@cherewaty cherewaty deleted the jc/fix-icon-button-test branch June 7, 2018 18:37
This was referenced Jun 7, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnC-80 JohnC-80 JohnC-80 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cherewaty @JohnC-80