OKAPI-1191: NumberFormatException in timerId halts Okapi #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianladisch
force-pushed
the
OKAPI-1191-timer-NumberFormatException
branch
from
434b487
to
10e802c
Compare
https://folio-org.atlassian.net/browse/OKAPI-1191 Avoid NumberFormatException in timerId. Approach: Find `_` from the end (not from the beginning) because the tenantId may contain `_`. Wrap parsing into try-catch to gracefully handle all parse errors. Move the timerId code into TenantProductSeq class. Use product_seq only in module descriptor and in APIs; use tenant_product_seq in all other places. Rename timerId variable to tenantProductSeq or productSeq.
julianladisch
force-pushed
the
OKAPI-1191-timer-NumberFormatException
branch
from
10e802c
to
281a123
Compare
steveellis
approved these changes
Sep 14, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/OKAPI-1191
Avoid NumberFormatException in timerId.
Approach:
Find
_from the end (not from the beginning) because the tenantId may contain_.Wrap parsing into try-catch to gracefully handle all parse errors.
Move the timerId code into TenantProductSeq class.
Use product_seq only in module descriptor and in APIs; use tenant_product_seq in all other places.
Rename timerId variable to tenantProductSeq or productSeq.