EUREKA-79: skip retrieving token if system user is disabled

NEWS.md

@@ -4,7 +4,7 @@
 * [MODPUBSUB-283](https://folio-org.atlassian.net/browse/MODPUBSUB-283) Upgrade to RMB 35.1.1, folio-di-support 2.0.1, kafka-clients 3.6.0
 * [MODPUBSUB-282](https://folio-org.atlassian.net/browse/MODPUBSUB-282) Allow disabling system user
 * [MODPUBSUB-278](https://folio-org.atlassian.net/browse/MODPUBSUB-278) Remove default user password
-* 
+* [EUREKA-79](https://folio-org.atlassian.net/browse/EUREKA-79) Skip retrieving token if system user is disabled
 
 ## 2023-10-13 v2.11.0
 * [FOLIO-3678](https://issues.folio.org/browse/FOLIO-3678) Use API-related Workflows

mod-pubsub-server/src/main/java/org/folio/services/impl/KafkaConsumerServiceImpl.java

@@ -1,5 +1,4 @@
 package org.folio.services.impl;
-
 import io.vertx.core.AsyncResult;
 import io.vertx.core.Future;
 import io.vertx.core.Handler;
@@ -167,7 +166,7 @@ protected Future<Void> deliverEvent(Event event, OkapiConnectionParams params) {
   protected Handler<AsyncResult<RestUtil.WrappedResponse>> getEventDeliveredHandler(Event event, String tenantId, MessagingModule subscriber, OkapiConnectionParams params, Map<MessagingModule, AtomicInteger> retry) {
     retry.get(subscriber).incrementAndGet();
     return ar -> {
-      LOGGER.info("Delivering was complete. Checking for response...");
+      LOGGER.info("Delivering for event with ID {} was complete. Checking for response...", event.getId());
       if (ar.failed()) {
         String errorMessage = format("%s event with id '%s' was not delivered to %s", event.getEventType(), event.getId(), subscriber.getSubscriberCallback());
         LOGGER.error(errorMessage, ar.cause());

mod-pubsub-server/src/main/java/org/folio/services/impl/SecurityManagerImpl.java

@@ -79,6 +79,11 @@ public Future<String> getAccessToken(OkapiConnectionParams params) {
     params.setToken(EMPTY);
     final String tenantId = params.getTenantId();
 
+    if (!systemUserConfig.isCreateUser()) {
+      LOGGER.info("getAccessToken:: System user is disabled. Using empty token for tenant {}", tenantId);
+      return Future.succeededFuture(EMPTY);
+    }
+
     String cachedAccessToken = cache.getAccessToken(tenantId);
     if (!StringUtils.isEmpty(cachedAccessToken)) {
       LOGGER.debug("getAccessToken:: Using cached access token for tenant {}",

mod-pubsub-server/src/test/java/org/folio/services/impl/SecurityManagerTest.java

@@ -344,6 +344,18 @@ public void shoulReturnFailedFutureWhenTokenCacheIsEmptyAndPubSubUserLoginFailed
     });
   }
 
+  @Test
+  public void shouldReturnSuccessFutureWithEmptyTokenIfSystemUserCreationDisabled(TestContext context) {
+    OkapiConnectionParams params = new OkapiConnectionParams(headers, vertx);
+
+    Future<String> future = securityManagerNoSystemUser.getAccessToken(params);
+
+    future.onComplete(ar -> {
+      context.assertTrue(ar.succeeded());
+      context.assertEquals("", ar.result());
+    });
+  }
+
   @Test
   public void shouldUpdateExistingUser(TestContext context) {
     final String userId = UUID.randomUUID().toString();