Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inventory-hierarchy): add Library code, Location id, material type #949

Merged
merged 7 commits into from
Feb 19, 2024
Merged

feat(inventory-hierarchy): add Library code, Location id, material type #949

merged 7 commits into from
Feb 19, 2024

Conversation

Roman-Leshchenko
Copy link
Contributor

@Roman-Leshchenko Roman-Leshchenko commented Nov 6, 2023 •
edited by psmagin
Loading

Purpose

add to rtac response fields Library code, Location id, material type
https://folio-org.atlassian.net/browse/MODINVSTOR-1133

Approach

Change SQL query, add fields to response

Changes Checklist

  • API Changes: List any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Specify any database schema changes and their impact.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Note added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • NEWS: Ensure that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

edge-rtac
mod-rtac

@Roman-Leshchenko Roman-Leshchenko self-assigned this Nov 6, 2023
@Roman-Leshchenko Roman-Leshchenko requested a review from a team as a code owner November 6, 2023 21:43
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@psmagin
Copy link
Contributor

psmagin commented Nov 16, 2023

As this PR is not for merge and not ready for review I've converted it to draft.

@psmagin psmagin marked this pull request as draft November 16, 2023 12:02
@Roman-Leshchenko Roman-Leshchenko marked this pull request as ready for review February 13, 2024 15:30
@Roman-Leshchenko Roman-Leshchenko mentioned this pull request Feb 13, 2024
Merged
psmagin
psmagin requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@psmagin psmagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update NEWS file

ramls/inventory-hierarchy/inventory-instance-records.json Outdated Show resolved Hide resolved
src/main/resources/templates/db_scripts/schema.json Outdated Show resolved Hide resolved
src/test/java/org/folio/rest/api/InventoryHierarchyViewTest.java Outdated Show resolved Hide resolved
@psmagin psmagin changed the title feat(MODINVSTOR-1133): add Library code, Location id, material type feat(inventory-hierarchy): add Library code, Location id, material type Feb 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@psmagin psmagin merged commit ab31531 into master Feb 19, 2024
7 checks passed
@psmagin psmagin deleted the MODINVSTOR-1133 branch February 19, 2024 14:47
@vijay-eis vijay-eis restored the MODINVSTOR-1133 branch February 20, 2024 05:06
@psmagin psmagin deleted the MODINVSTOR-1133 branch February 22, 2024 14:42
@psmagin psmagin restored the MODINVSTOR-1133 branch February 22, 2024 14:42
@psmagin psmagin deleted the MODINVSTOR-1133 branch March 19, 2024 08:40
@vijay-eis vijay-eis restored the MODINVSTOR-1133 branch April 10, 2024 14:34
@psmagin psmagin deleted the MODINVSTOR-1133 branch October 29, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf approved these changes

@psmagin psmagin psmagin approved these changes

@TsaghikKhachatryan TsaghikKhachatryan Awaiting requested review from TsaghikKhachatryan TsaghikKhachatryan is a code owner automatically assigned from folio-org/spitfire-backend

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

@andrei-razumnov andrei-razumnov Awaiting requested review from andrei-razumnov andrei-razumnov is a code owner automatically assigned from folio-org/spitfire-backend

@GeloPakDev1 GeloPakDev1 Awaiting requested review from GeloPakDev1 GeloPakDev1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@Roman-Leshchenko Roman-Leshchenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Roman-Leshchenko @psmagin @mukhiddin-yusuf @humonest-one