Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(domain-events): create env variable to control number of partitions for topics #947

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix(domain-events): create env variable to control number of partitions for topics #947

merged 1 commit into from
Nov 2, 2023

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Nov 1, 2023 •
edited
Loading

Purpose

Add support for controlling a number of partitions for topics created on module startup.

Approach

Add KAFKA_DOMAIN_TOPIC_NUM_PARTITIONS env variable with default value = 50

Changes Checklist

  • API Changes: List any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Specify any database schema changes and their impact.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Note added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • NEWS: Ensure that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://issues.folio.org/browse/MODINVSTOR-1131

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@psmagin psmagin self-assigned this Nov 1, 2023
@psmagin psmagin marked this pull request as ready for review November 1, 2023 18:05
@psmagin psmagin requested a review from a team as a code owner November 1, 2023 18:06
@psmagin psmagin merged commit 005a018 into master Nov 2, 2023
1 check passed
@psmagin psmagin deleted the MODINVSTOR-1131 branch November 2, 2023 10:42
psmagin added a commit that referenced this pull request Nov 2, 2023
@psmagin
fix(domain-events): create env variable to control number of partitio…
a828a36 
…ns for topics (#947)

Closes: MODINVSTOR-1131
(cherry picked from commit 005a018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-razumnov andrei-razumnov andrei-razumnov approved these changes

@TsaghikKhachatryan TsaghikKhachatryan TsaghikKhachatryan approved these changes

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

@GeloPakDev1 GeloPakDev1 Awaiting requested review from GeloPakDev1 GeloPakDev1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psmagin @TsaghikKhachatryan @andrei-razumnov