Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pub-period-migration) revert the publication period migration changes. #1135

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(pub-period-migration) revert the publication period migration changes. #1135

wants to merge 4 commits into from

Conversation

SvitlanaKovalova1
Copy link
Contributor

@SvitlanaKovalova1 SvitlanaKovalova1 commented Jan 10, 2025 •
edited
Loading

Purpose

MODINVSTOR-1280 Revert the changes made in the PR #1100 and use a single instance.json schema without publicationPeriod field for the request/response API and for working with the DB.

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

@SvitlanaKovalova1 SvitlanaKovalova1 changed the title feat(pub-period-migration) revert the publication period migration ch… feat(pub-period-migration) revert the publication period migration changes. Jan 10, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SvitlanaKovalova1 SvitlanaKovalova1 marked this pull request as ready for review January 10, 2025 14:08
@SvitlanaKovalova1 SvitlanaKovalova1 requested a review from a team as a code owner January 10, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmagin psmagin Awaiting requested review from psmagin psmagin is a code owner automatically assigned from folio-org/spitfire-backend

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SvitlanaKovalova1