MODINVSTOR-1237: Don't warn about expected 403 from user-tenant #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ants https://folio-org.atlassian.net/browse/MODINVSTOR-1237 See https://folio-org.atlassian.net/browse/MODINVSTOR-1114 why it is expected that ConsortiumDataCache gets a 403 response when calling /user-tenants. That 403 causes this log entry: `WARN ConsortiumDataCache loadConsortiumData:: Error loading consortium data, tenantId: 'diku' response status: '403', body: 'Access for user 'diku_admin' (2579bfce-29bd-435a-bac6-5e1b95588e31) requires permission: user-tenants.collection.get'` Warning about an expected 403 is misleading. Solution: INFO ConsortiumDataCache loadConsortiumData:: Skipping for tenant diku because /user-tenants?limit=1 returns 403 (forbidden)
julianladisch
requested review from
psmagin,
viacheslavkol,
mukhiddin-yusuf and
viacheslavpoliakov
psmagin
approved these changes
Jul 26, 2024
KaterynaSenchenko
approved these changes
Jul 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/MODINVSTOR-1237
See https://folio-org.atlassian.net/browse/MODINVSTOR-1114 why it is expected that ConsortiumDataCache gets a 403 response when calling /user-tenants.
That 403 causes this log entry:
WARN ConsortiumDataCache loadConsortiumData:: Error loading consortium data, tenantId: 'diku' response status: '403', body: 'Access for user 'diku_admin' (2579bfce-29bd-435a-bac6-5e1b95588e31) requires permission: user-tenants.collection.get'Warning about an expected 403 is misleading.
Solution:
INFO ConsortiumDataCache loadConsortiumData:: Skipping for tenant diku because /user-tenants?limit=1 returns 403 (forbidden)Purpose
Don't warn about the expected 403 from user-tenant.
Approach
Convert warning into info log entry.
Changes Checklist
Related Issues
https://folio-org.atlassian.net/browse/MODINVSTOR-1237