MODINVSTOR-1219: Do not return routing service points by default #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksandrVidinieiev
requested review from
MagzhanArtykov,
alexanderkurash and
roman-barannyk
OleksandrVidinieiev
requested review from
psmagin,
viacheslavkol,
mukhiddin-yusuf and
viacheslavpoliakov
and removed request for
a team
psmagin
reviewed
May 22, 2024
|
psmagin
approved these changes
May 22, 2024
roman-barannyk
approved these changes
May 23, 2024
alexanderkurash
approved these changes
May 23, 2024
alexanderkurash
added a commit
that referenced
this pull request
Nov 12, 2024
* MODINVSTOR-1179 Add ecsRequestRouting field to service point schema (#1010) * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Bump service-point.raml version --------- Co-authored-by: alexanderkurash <[email protected]> * MODINVSTOR-1219: Do not return routing service points by default (#1022) * MODINVSTOR-1219 Do not return routing service points by default * MODINVSTOR-1219 Fix formatting * MODINVSTOR-1219 Extend test * MODINVSTOR-1219 Update query parameter description * MODINVSTOR-1219 Fix checkstyle violations * MODINVSTOR-1219 Test refactoring * MODINVSTOR-1219 Test refactoring * MODINVSTOR-1219 Put filter in front of original query, update tests * MODINVSTOR-1219 Minor refactoring * MODINVSTOR-1245: Implement synchronization operation for service point events (#1088) * MODINVSTOR-1245: Implement synchronization operation for service point event * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Comply with check style * MODINVSTOR-1245: Comply with check style * MODINVSTOR-1245: Add api test * MODINVSTOR-1245: Rename service point event * MODINVSTOR-1245: Rename tests * MODINVSTOR-1245: Replace service point creation with service implementation * MODINVSTOR-1245: Add validation for hold shelf expiry and pick up location * MODINVSTOR-1245: Replace system-stubs-junit4 instead of hard-coded env variable * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Add logs * Fix mockConsortiumTenants after merge * Disable canRequestOaiPmhViewWhenEmptyDb test * MODINVSTOR-1262 Re-enable disabled tests * MODINVSTOR-1262 Update NEWS * MODINVSTOR-1262 Remove unneeded dependency * MODINVSTOR-1262 improve test coverage, update readme * MODINVSTOR-1262 improve test coverage * MODINVSTOR-1262 improve test coverage * MODINVSTOR-1262 improve test coverage * MODINVSTOR-1262 add missing permission * MODINVSTOR-1262 add test coverage * MODINVSTOR-1262 add test coverage * MODINVSTOR-1262 fix code smell * MODINVSTOR-1262 fix code smell * MODINVSTOR-1262 Move ECS TLR news to In progress --------- Co-authored-by: Magzhan <[email protected]> Co-authored-by: OleksandrVidinieiev <[email protected]> Co-authored-by: Oleksandr Vidinieiev <[email protected]> Co-authored-by: Maksat <[email protected]> Co-authored-by: Roman_Barannyk <[email protected]> Co-authored-by: Roman Barannyk <[email protected]>
roman-barannyk
pushed a commit
that referenced
this pull request
Dec 1, 2024
* MODINVSTOR-1179 Add ecsRequestRouting field to service point schema (#1010) * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Bump service-point.raml version --------- Co-authored-by: alexanderkurash <[email protected]> * MODINVSTOR-1219: Do not return routing service points by default (#1022) * MODINVSTOR-1219 Do not return routing service points by default * MODINVSTOR-1219 Fix formatting * MODINVSTOR-1219 Extend test * MODINVSTOR-1219 Update query parameter description * MODINVSTOR-1219 Fix checkstyle violations * MODINVSTOR-1219 Test refactoring * MODINVSTOR-1219 Test refactoring * MODINVSTOR-1219 Put filter in front of original query, update tests * MODINVSTOR-1219 Minor refactoring * MODINVSTOR-1245: Implement synchronization operation for service point events (#1088) * MODINVSTOR-1245: Implement synchronization operation for service point event * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Comply with check style * MODINVSTOR-1245: Comply with check style * MODINVSTOR-1245: Add api test * MODINVSTOR-1245: Rename service point event * MODINVSTOR-1245: Rename tests * MODINVSTOR-1245: Replace service point creation with service implementation * MODINVSTOR-1245: Add validation for hold shelf expiry and pick up location * MODINVSTOR-1245: Replace system-stubs-junit4 instead of hard-coded env variable * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Add logs * Fix mockConsortiumTenants after merge * Disable canRequestOaiPmhViewWhenEmptyDb test * MODINVSTOR-1262 Re-enable disabled tests * MODINVSTOR-1262 Update NEWS * MODINVSTOR-1262 Remove unneeded dependency * MODINVSTOR-1262 improve test coverage, update readme * MODINVSTOR-1262 improve test coverage * MODINVSTOR-1262 improve test coverage * MODINVSTOR-1262 improve test coverage * MODINVSTOR-1262 add missing permission * MODINVSTOR-1262 add test coverage * MODINVSTOR-1262 add test coverage * MODINVSTOR-1262 fix code smell * MODINVSTOR-1262 fix code smell * MODINVSTOR-1262 Move ECS TLR news to In progress --------- Co-authored-by: Magzhan <[email protected]> Co-authored-by: OleksandrVidinieiev <[email protected]> Co-authored-by: Oleksandr Vidinieiev <[email protected]> Co-authored-by: Maksat <[email protected]> Co-authored-by: Roman_Barannyk <[email protected]> Co-authored-by: Roman Barannyk <[email protected]> (cherry picked from commit 810764f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Return ECS routing service points in response to
GET /service-pointsonly when explicitly requested.MODINVSTOR-1219
Approach
Introduce a new query parameter
includeRoutingServicePointstoGET /service-pointsendpoint. Set this flag tofalseby default. Return ECS routing service points only when it is explicitly set totrue.Changes Checklist
Related Issues
List any Jira issues related to this pull request.
Learning and Resources (if applicable)
Discuss any research conducted during the development of this pull request. Include links to relevant blog posts, patterns, libraries, or addons that were used to solve the problem.
Screenshots (if applicable)
If this pull request involves any visual changes or new features, consider including screenshots or GIFs to illustrate the changes.