Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locations): implement domain event production for location create/update/delete #1006

Merged
merged 1 commit into from
Mar 26, 2024
Merged

feat(locations): implement domain event production for location create/update/delete #1006

merged 1 commit into from
Mar 26, 2024

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Mar 25, 2024 •
edited
Loading

Purpose

Implement domain event production for location create/update/delete

Approach

  • move controller logic to service
  • create a domain publisher

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MODINVSTOR-1181

@psmagin psmagin self-assigned this Mar 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@psmagin psmagin marked this pull request as ready for review March 26, 2024 08:50
@psmagin psmagin requested a review from a team as a code owner March 26, 2024 08:50
@psmagin psmagin merged commit c3cb8b9 into master Mar 26, 2024
8 checks passed
@psmagin psmagin deleted the MODINVSTOR-1181 branch March 26, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viacheslavpoliakov viacheslavpoliakov viacheslavpoliakov approved these changes

@TsaghikKhachatryan TsaghikKhachatryan TsaghikKhachatryan approved these changes

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

@GeloPakDev1 GeloPakDev1 Awaiting requested review from GeloPakDev1 GeloPakDev1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psmagin @TsaghikKhachatryan @viacheslavpoliakov