Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODFIN-391]. Minimize amount of requests to retrieve transactions for ledger #443

Merged
merged 9 commits into from
Jan 9, 2025
Merged

[MODFIN-391]. Minimize amount of requests to retrieve transactions for ledger #443

merged 9 commits into from
Jan 9, 2025

Conversation

BKadirkhodjaev
Copy link
Contributor

@BKadirkhodjaev BKadirkhodjaev commented Jan 3, 2025 •
edited
Loading

Purpose

Approach

  • Create a new view to aggregate transaction totals
  • Create new API to serve the new view that aggregates transaction totals
  • Karate tests in mod-finance and cross-modules folders found no regression:

image
image

@BKadirkhodjaev BKadirkhodjaev marked this pull request as ready for review January 6, 2025 13:28
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@BKadirkhodjaev BKadirkhodjaev requested a review from a team January 6, 2025 16:42
@BKadirkhodjaev BKadirkhodjaev merged commit 14be5e8 into master Jan 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azizbekxm azizbekxm azizbekxm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BKadirkhodjaev @azizbekxm