[MODDATAIMP-953] [Poppy] Pass user information directly into Kafka #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncovercash
changed the title
ncovercash
requested review from
KaterynaSenchenko,
RuslanLavrov,
okolawole-ebsco and
a team
src/main/java/org/folio/service/file/SplitFileProcessingService.java
Outdated
Show resolved
Hide resolved
okolawole-ebsco
approved these changes
Oct 27, 2023
RuslanLavrov
approved these changes
Oct 27, 2023
KaterynaSenchenko
approved these changes
Oct 28, 2023
|
Kudos, SonarCloud Quality Gate passed! |
ncovercash
added a commit
that referenced
this pull request
Oct 30, 2023
) * [MODDATAIMP-953] Supply user permissions and ID to Kafka * Fix test compilation * log headers * Pare down user permissions to only ones that are desired * Try including all perms? * Don't include not system user ID * fix typo * Re-include * Add token to database * Add okapi permissions property/column * Update submodule * Use user credentials in S3 verticle * Remove system user * Undo autoformat on README * Remove permissions files * Fix tests * Fix permission * Fix nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poppy version of #312
Purpose
Operations involving acquisition units and invoices require information about the original user to determine if they are permitted to perform actions and are members of acquisition units.
Approach
Instead of using the system user, we store and pass the originating user's tokens, permissions, and user ID to Kafka/SRM when processing jobs.
Since this was the only time we needed to use the system user, the system user is also removed.