Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide complete minimal pom.xml for non-maven modules #22

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

julianladisch
Copy link
Contributor

Purpose

Give advice for non-maven modules.

Approach

Provide complete minimal pom.xml.

TODOS and Open Questions

Shared GitHub Action at https://github.com/folio-org/.github

@julianladisch julianladisch requested a review from a team as a code owner October 9, 2024 09:04
Copy link

sonarqubecloud bot commented Oct 9, 2024

Copy link

@MikeTaylor MikeTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super-helpful, thank you!

@MikeTaylor
Copy link

Seems my review doesn't count towards the two you need to merge this. What a stupid system. I think you will have to solicit someone with greater powers than mine, @julianladisch.

@dmtkachenko dmtkachenko merged commit c26b66b into folio-org:master Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants