EDGCOMMON-79. Add truststore options to configure Web Clients #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNosko
requested review from
TarasSpashchenko,
steveellis,
azizbekxm and
BKadirkhodjaev
BKadirkhodjaev
approved these changes
May 20, 2024
azizbekxm
reviewed
May 20, 2024
src/main/java/org/folio/edge/core/utils/OkapiClientFactoryInitializer.java
Outdated
Show resolved
Hide resolved
…nt edge modules that use Net server
azizbekxm
approved these changes
May 20, 2024
BKadirkhodjaev
approved these changes
May 20, 2024
steveellis
reviewed
May 20, 2024
steveellis
reviewed
May 20, 2024
TarasSpashchenko
approved these changes
May 20, 2024
|
|
|
This was referenced May 21, 2024
Merged
This was referenced May 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document things better
Change keyCertOptions to trustStoreOptions for configuring Web Clients
Make trustStoreOptions as optional for configuring Web Clients
Introduce OkapiClientFcatoryIntializer that allows to delete factories from all edge-modules. Logic to create okapi clients will be -encapsulated only in edge-common
Usages of these changes:
https://github.com/folio-org/edge-orders/pull/74/files
folio-org/edge-rtac#68
https://github.com/folio-org/edge-lti-courses/pull/28/files
https://github.com/folio-org/edge-patron/pull/111/files
https://github.com/folio-org/edge-oai-pmh/pull/115/files
folio-org/edge-ncip#40