Add the ability to specify the seed data path #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyuzakiKK
force-pushed
the
seed_and_data
branch
from
9585d42
to
6bcb42d
Compare
folbricht
reviewed
Dec 7, 2022
When using the `--seed foo.caibx` option, Desync expects to find the data in foo, next to the provided .caibx file. While this is a valid assumption for files, it requires additional steps when the data is a block device. For example a common suggestion in those cases is to create a symlink next to the seed index. Instead, now `--seed` gains the ability to explicitly set a path for the data blob. The syntax becomes: `--seed /path/to/index.caibx:/path/to/data`. If the colon is missing, the old behavior of expecting the data next to the index file will still be used by default. Fixes: folbricht#228 Signed-off-by: Ludovico de Nittis <[email protected]>
RyuzakiKK
force-pushed
the
seed_and_data
branch
from
6bcb42d
to
3af4f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
--seed foo.caibxoption, Desync expects to find the data in foo, next to the provided .caibx file.While this is a valid assumption for files, it requires additional steps when the data is a block device. For example a common suggestion in those cases is to create a symlink next to the seed index.
Instead, now
--seedgains the ability to explicitly set a path for the data blob. The syntax becomes:--seed /path/to/index.caibx:/path/to/data.If the colon is missing, the old behavior of expecting the data next to the index file will still be used by default.
Fixes: #228