Speed up VerifyIndex #206
Merged
Speed up VerifyIndex #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludovico de Nittis <[email protected]>
We can reuse the validate() function of FileSeedSegment and avoid duplicating the code here. Signed-off-by: Ludovico de Nittis <[email protected]>
If we send a single chunk to every Goroutine, the workers will complete their task immediately and then will wait for a new chunk to validate. If instead we group together multiple chunks we can improve the overall performance. For example, in my test machine, the required time to verify an index that pointed to a 5gb image took 30 seconds, and with this patch it dropped to 24 seconds. Signed-off-by: Ludovico de Nittis <[email protected]>
folbricht
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some tests for VerifyIndex
Reduce code duplication while verifying an index
We can reuse the validate() function of FileSeedSegment and avoid
duplicating the code here.
Feed multiple chunks to the workers while verifying an index
If we send a single chunk to every Goroutine, the workers will complete
their task immediately and then will wait for a new chunk to validate.
If instead we group together multiple chunks we can improve the overall
performance.
For example, in my test machine, the required time to verify an index
that pointed to a 5gb image took 30 seconds, and with this patch it
dropped to 24 seconds.