Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComfyUI-Impact-Pack and ComfyUI-Impact-Subpack #22

Merged
merged 8 commits into from
Feb 18, 2024
Merged

Conversation

fofr
Copy link
Owner

@fofr fofr commented Feb 18, 2024

Follow up to #20

  • Uses a forked version of Impact Pack (see https://github.com/fofr/ComfyUI-Impact-Pack):
    • prevents any automatic installation
    • loads the impact_subpack as a submodule
    • includes a default config
    • prevents automatic deletion of the impact_subpack directory if .git is missing
  • Adds SAM and Ultralytics weights
  • Automatically downloads Ultralytics weights if a UltralyticsDetectorBox node is used

Closes #13

@fofr fofr mentioned this pull request Feb 18, 2024
@fofr fofr changed the title Add impact pack Add ComfyUI-Impact-Pack and ComfyUI-Impact-Subpack Feb 18, 2024
@fofr
Copy link
Owner Author

fofr commented Feb 18, 2024

@digitaljohn I've pushed this branch to this model:
https://replicate.com/fofr/comfyui-prototype

If you want to give it a go and see if there are any problems.

@fofr
Copy link
Owner Author

fofr commented Feb 18, 2024

My basic test has worked, using one of the workflows from the tutorials repo:
https://replicate.com/p/iutngslbdyoalv55ew56ei42yy

@fofr fofr merged commit edad734 into main Feb 18, 2024
@fofr fofr deleted the feat/add-impact-pack branch February 18, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ComfyUI-Impact-Pack
2 participants