-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
392 zone filters + continuous and nulls refactor #451
Conversation
Deploy to live
…ns we can setState of our filterValues multiple times if needed and if the values haven't changed it won't be published. This should make it easier to resolve some of our sequencing problems for not running the filterData functions multiple redundant times. - Adds a 'set' method to the continuous filter control, which centralizes where all the UI and state elements get set at once. - Refactors the router to use this set method.
…m to be recalculated when changing zone types. zone-level data sets now getting proper min/max levels on load. Temporarily removes fraction_black for user testing to avoid race discussion - we will be adding all races in v2.
…nuous 392 zone filters part of continuous
…e proper min/max levels, and clears any activated filters
TODO: the Nulls checkbox is now broken - throws an error.
…ould consider refactoring.
Due to the fact that we're having a user test tonight at 8pm, I've merged this into the live website so that the zone-based filters will operate correctly for this test. This PR is into dev, so if there are any changes needed to the PR I'll work out the Git merging needed to get everything up to date when it's all resolved. @ptgott this PR is in conflict with your PR #444 and also undues some of your code on the nulls from a couple weeks ago. I'm sorry for that, it's very soon for a refactor and I hope it's not too much of a dissapointment! There were a few conflicts and bugs in the existing system and it was easier for me to rearrange some of it rather than patch. |
Changing zone types doesn't seem to be clearing the zone-based filters the way we expect. @NealHumphrey |
@NealHumphrey : as discussed, I'll approve and merge this PR and write up the outstanding bugs as new issues so that other PRs are on top of this one. |
This pull request includes a variety of changes to the filterControl elements, primarily for continuous controls but also for date controls, and to the connected filter.js, router.js. Note that this PR also includes #448 which did some simple rearrangment of the continuous filter. Included:
nullsShown.<source>
in favor of using the 3rd value of thefilterValues.
state array (i.e.[min,max,nullValue]
). The URL encoding code already added this to the state, which was duplicative, and we want the checkboxes to cause the same reactions in the UI as the sliders re: pillboxes etc. - @ptgott created the nullsShown state to separate the checkboxes from the code that executes filters, but that turned out to not be the desired behavior and maintaining two separate states was more complexity.This also fixes a few bugs that existed in the current dev branch:
Additional bonus feature: