Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] [NP-3231] Scrolling step wizard view (experimental) #4723

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[DNM] [NP-3231] Scrolling step wizard view (experimental) #4723

wants to merge 6 commits into from

Conversation

KernelDeimos
Copy link
Contributor

This PR adds ScrollingStepWizardView which is not enabled by default. I think having it in the repository will make testing or future use easier.

Current known issues:

  • Seems to have quirks with FlatteningCapabilityWizardlet, but uncertain - might only occur when using FileUploadView
  • Saves too quickly, resetting data as user enters it. A simple debounce can probably fix this

@google-cla google-cla bot added the cla: yes label Feb 1, 2021
@KernelDeimos KernelDeimos changed the title [NP-3231] Scrolling step wizard view (experimental) [D<M] [NP-3231] Scrolling step wizard view (experimental) Feb 23, 2021
@KernelDeimos KernelDeimos changed the title [D<M] [NP-3231] Scrolling step wizard view (experimental) [DNM] [NP-3231] Scrolling step wizard view (experimental) Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KernelDeimos