Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new logoImages model #4338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carl-zzz
Copy link
Contributor

@carl-zzz carl-zzz commented Nov 19, 2020

The new logoImages model contains 6 different images to replace the current largeLogo:

  • smallLightOnDark
  • smallDarkOnLight
  • mediumLightOnDark
  • mediumDarkOnLight
  • largeLightOnDark
  • largeDarkOnLight
    However, I think we should standardize the 'logo' (maybe with constant length and width) as well as other sizes of logoImages @jlhughes @kgrgreer
    And I keep largeLogo and largeLogoEnabled for now, and will be removed later, and I also keep the 'logo' because sometime companies/we only need the logo without the slogan or brand word

Related Nanopay changes: https://github.com/nanoPayinc/NANOPAY/pull/11175

@google-cla google-cla bot added the cla: yes label Nov 19, 2020
@jlhughes
Copy link
Collaborator

jlhughes commented Nov 19, 2020

re: logo - with and without slogan, branding. This is the intent of small, medium, large. Small presumably without slogan, branding unless they provided something that works in a small space.
Perhaps we should also add the favicon here as well.
If we go the route of 'logo', then rather than small, ,,, light/dark, it's

  • banner
  • login
  • ...
  • email
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants