Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for plugins in fnext #1385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for plugins in fnext #1385

wants to merge 1 commit into from

Conversation

riconnon
Copy link
Contributor

  • What I did

Preliminary support for dynamically loadable extensions. Doesn't (yet) include ability to specify loading them at runtime.

  • How I did it

Uses golang "plugins" to load plugins from shared libraries

  • How to verify it

Good question... I've verified it myself using my extensions but maybe we should have some automated tests with dummy plugins.

  • One line description for the changelog

Add support for dynamically loading extensions

  • One moving picture involving robots (not mandatory but encouraged)

Robot

@rdallman
Copy link
Contributor

i'm 'with the program' on moving call overrider to fnext, short of getting rid of it altogether. i do think that we should probably avoid adding the .so plugin stuff however and just have the package using the call overrider bake it in at compile time like all the other plugins in fnext - i appreciate trying it out, it's something we've been curious about for a while, but there is not strong buy in from what i can tell at this time anyway (we could have a wider discussion, of course...) and we'd need deployment tools to manage that among other things.

@riconnon
Copy link
Contributor Author

I would also prefer to see CallOverrider removed altogether.
My initial thinking was that if the "exts" map that it handles was moved to the call object then this would just be a CallListener
Happy to go through and do that work instead if it's preferred.

@rdallman
Copy link
Contributor

My initial thinking was that if the "exts" map that it handles was moved to the call object then this would just be a CallListener

it's early, but that sounds like a great idea to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants