Generate request id for each provider request. #387
+47
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JadeRedworth
changed the title
msgodf
reviewed
Aug 17, 2018
| @@ -12,11 +12,12 @@ import ( | |||
|
|
|||
| "github.com/fnproject/cli/client" | |||
| "github.com/fnproject/cli/common" | |||
| fnclient "github.com/fnproject/fn_go/client" | |||
| fnclient "github.com/fnproject/fn_go/client" | |||
There was a problem hiding this comment.
There's some trailing whitespace here.
msgodf
reviewed
Aug 17, 2018
| @@ -17,6 +20,16 @@ import ( | |||
| "github.com/urfave/cli" | |||
| ) | |||
|
|
|||
| func getRequestID() string { | |||
There was a problem hiding this comment.
What's the format of these IDs? It might be worth giving an example in a comment above the function.
|
Is this not already happening in the fn_go layer due to this: |
|
@mantree It is, but now we've added the request ID to the context from the CLI for all requests which allows the user to see the request-id. |
|
Ah ok, I was only thinking to make it visible when DEBUG=1. |
JadeRedworth
force-pushed
the
request-id
branch
from
d4b4fa7
to
ec6c02c
Compare
…vider requests. remove func folder Bump fn_go to 0.2.12. Squashed commit of the following: commit d4b4fa7 Author: JadeRedworth <[email protected]> Date: Fri Aug 17 16:45:22 2018 +0100 move generation of request id to common.go commit 70f44cc Author: JadeRedworth <[email protected]> Date: Fri Aug 17 14:32:55 2018 +0100 remove func folder commit 735b2eb Author: JadeRedworth <[email protected]> Date: Fri Aug 17 11:40:23 2018 +0100 Create request-id to be set as a header on the request for oracle provider requests.
JadeRedworth
force-pushed
the
request-id
branch
from
0ab40ff
to
1ef2da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the request-id on the context to be used for each provider request.