Amending select * from table alias #973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You made
select * from table alias
work to some extent with PR #952 (addressing issue #945), by doing thecolumn_result_t
handling right.In order to make
select * from table alias
fully functional, the table name collector and column names getter should be amended as well.select(asterisk<als_a>())
possible w/o explicitfrom<als_a>()
; see table name collector.a.*
instead of*
; see column names getter.storage_t::dump()
now serializes withcontext.skip_table_names = false
just likestorage_t::prepare_impl()
seestorage_t::dump()
Question: wouldn't it be safer that
statement_serializator<alias_column_t<>>
always qualifies the column with the table name (as if by seralizing withcontext.skip_table_names = false
) since it is an aliased column?