Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amending select * from table alias #973

Merged
merged 11 commits into from
Mar 21, 2022

Conversation

trueqbit
Copy link
Collaborator

You made select * from table alias work to some extent with PR #952 (addressing issue #945), by doing the column_result_t handling right.

In order to make select * from table alias fully functional, the table name collector and column names getter should be amended as well.

Question: wouldn't it be safer that statement_serializator<alias_column_t<>> always qualifies the column with the table name (as if by seralizing with context.skip_table_names = false) since it is an aliased column?

@fnc12 fnc12 merged commit a674f58 into fnc12:dev Mar 21, 2022
@trueqbit trueqbit deleted the issues/select_asterisk_alias branch March 21, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants