-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcpkg port 1.8 fixes #1121
vcpkg port 1.8 fixes #1121
Conversation
…o true" This reverts commit c5e84c9.
Addressed issue fnc12#1107
Amends commit 7bb1a39
@@ -15,18 +15,28 @@ struct Rect { | |||
int y = 0; | |||
int width = 0; | |||
int height = 0; | |||
|
|||
#ifndef SQLITE_ORM_AGGREGATE_NSDMI_SUPPORTED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you repro a bug which requires this macro? IDK how to do that and that's why I forget to put it sometimes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, NSDMI is a core capability of a compiler, so you have to compile it with a compiler that does not have it.
Anyway, I suggest that the v1.8 band is the last one in which we support pre-C++14 compilers. As you may have noticed, Martin Hořeňovský, the maintainer of Catch2, is not interested in maintaining compatibility. So the problem is that it is becoming more and more expensive to maintain compatibility on our side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it. Yes I agree with dropping pre-C++14 compilers support from next releases
In order to update vcpkg's sqlite-orm port, a few things needed to be addressed:
type_is_nullable<>
a specializable struct againmain()
function)Update (2023-01-15):
Currently unit tests fail with Visual C++ 2015 Update 3 as the minimal C++14 base compiler, as Catch2 v3 now requires a fully compliant C++14 compiler. Let's see what the decision is on the [feature request] (catchorg/Catch2#2624) I made.
Update (2023-01-24):
Now that Catch2 v3 requires a conforming C++14 compiler, legacy compilers like Visual C++ 2015 Update 3 can't be used anymore for compiling the unit tests. The library itself and its examples are still usable with legacy compilers.