Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Without rowid #654

Closed
denzor200 opened this issue Jan 28, 2021 · 5 comments
Closed

Without rowid #654

denzor200 opened this issue Jan 28, 2021 · 5 comments
Labels
bug

Comments

@denzor200
Copy link
Contributor

The _without_rowid parameter only affects the insert method. This parameter does not apply to insert_range. Is this expected?
@denzor200
Copy link
Contributor Author

statement serializator for insert:
https://github.com/fnc12/sqlite_orm/blob/dev/include/sqlite_orm/sqlite_orm.h#L10710
statemente serializator for insert_range:
https://github.com/fnc12/sqlite_orm/blob/dev/include/sqlite_orm/sqlite_orm.h#L10832

@fnc12
Copy link
Owner

fnc12 commented Jan 30, 2021

It looks like a bug

@fnc12 fnc12 added the bug label Jan 30, 2021
@denzor200
Copy link
Contributor Author

Ok, i will fix it in separate PR

denzor200 added a commit to denzor200/sqlite_orm that referenced this issue Jan 30, 2021
@denzor200
test 'InsertRange' was implemented (fixes fnc12#654)
d81e40a
denzor200 added a commit to denzor200/sqlite_orm that referenced this issue Jan 30, 2021
@denzor200
added 'without_rowid' checks for 'insert_range' impl (fixes fnc12#654)
4d8925c
@denzor200
Copy link
Contributor Author

Fixed.
#655

fnc12 added a commit that referenced this issue Jan 31, 2021
@fnc12
Merge pull request #655 from denzor200/bugfix/654-without_rowid
6102284 
#654 without rowid
@fnc12
Copy link
Owner

fnc12 commented Jan 31, 2021

@denzor200 thanks. I've merged it a minute ago.

@fnc12 fnc12 closed this as completed Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fnc12 @denzor200