Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operators should be in internal namespace #1047

Closed
kiwixz opened this issue Jun 3, 2022 · 2 comments · Fixed by #1159
Closed

Operators should be in internal namespace #1047

kiwixz opened this issue Jun 3, 2022 · 2 comments · Fixed by #1159
Labels
enhancement

Comments

@kiwixz
Copy link

kiwixz commented Jun 3, 2022

Operators defined here should be in the internal namespace (the same one as expression) so they can be found by ADL.
Or in the global namespace if you prefer.

Goldbolt if you want to play with it: https://godbolt.org/z/9ofP3rvd4.

Thanks for the awesome library !
@trueqbit trueqbit mentioned this issue Mar 18, 2023
Merged
@trueqbit trueqbit linked a pull request Mar 18, 2023 that will close this issue
Operators should be in internal namespace #1159
Merged
trueqbit added a commit that referenced this issue Mar 19, 2023
@trueqbit
Merge pull request #1159 from FireDaemon/issues/#1047
d51e3cf 
Operators should be in internal namespace
@fnc12
Copy link
Owner

fnc12 commented Mar 22, 2023

@kiwixz please check dev branch. It has to be fixed

@kiwixz
Copy link
Author

kiwixz commented Mar 22, 2023

Its fixed indeed, thanks!

@kiwixz kiwixz closed this as completed Mar 22, 2023
This was referenced Apr 1, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Operators should be in internal namespace FireDaemon/sqlite_orm
2 participants
@fnc12 @kiwixz