Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit message check (Github Action workflow) does not work as expected #269

Open
1 of 2 tasks
fnagel opened this issue Nov 30, 2023 · 0 comments
Open
1 of 2 tasks

Commit message check (Github Action workflow) does not work as expected #269

fnagel opened this issue Nov 30, 2023 · 0 comments
Labels
bug help wanted

Comments

@fnagel
Copy link
Owner

fnagel commented Nov 30, 2023 •
edited
Loading

Our commit message check does not work as expected. Following issues:

  • Always make sure to check latest commit message (even if a commit message has been changed using --amend)
  • Check line length

More info: GsActions/commit-message-checker#95
Test PR: #268
fnagel added a commit that referenced this issue Nov 30, 2023
@fnagel
[TASK] Make sure to check latest commit message
e87d80a 
This change makes sure we always check the latest commit message
and not an outdated one. This is needed for updated RPs.

Related to #269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fnagel