Address build failures when using Tip-of-Tree clang. #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Oct 3, 2024
include/fmt/base.h
Outdated
| @@ -2667,7 +2667,7 @@ template <typename... T> struct fstring { | |||
| template <typename S, | |||
| FMT_ENABLE_IF(std::is_convertible<const S&, string_view>::value)> | |||
| FMT_CONSTEVAL FMT_ALWAYS_INLINE fstring(const S& s) : str(s) { | |||
| FMT_CONSTEXPR auto sv = string_view(S()); | |||
| auto sv = string_view(s); | |||
There was a problem hiding this comment.
Overall looks correct but unfortunately this breaks a (somewhat limited) test that was supposed to catch multiple evaluations. Maybe we could fix it by using str here which will ensure that conversion is done once?
There was a problem hiding this comment.
I just revised it to use 'str'
Hope the CI will pass.
When using ToT clang to build fmtlib, it complains 'sv' is not initialized by a constant expression. This patch addresses this issue.
vitaut
approved these changes
Oct 3, 2024
|
Looks like all CI build passed. |
|
Merged, thanks! |
jiulongw
added a commit
to vibeus/fmt
that referenced
this pull request
Nov 6, 2024
Backport fmtlib#4187 to 11.0.2 See: fmtlib#4218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ToT clang to build fmtlib, it complains 'sv' is not initialized by a constant expression. This patch addresses this issue.