Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove whitespace in operator"" _a #3608

Closed
wants to merge 1 commit into from

Conversation

danakj
Copy link
Contributor

@danakj danakj commented Aug 23, 2023

Clang 18 warns about this whitespace.

third_party/fmt/include/fmt/format.h:4417:27: warning: identifier '_a' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
 4417 | constexpr auto operator"" _a(const char* s, size_t) -> detail::udl_arg<char> {
      |                ~~~~~~~~~~~^~
      |                operator""_a
1 warning generated.

Resolves #3607

Clang 18 warns about this whitespace.

Resolves fmtlib#3607
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR but it looks like it is causing an error in gcc.

@danakj
Copy link
Contributor Author

danakj commented Aug 23, 2023

Hmm, yes. I see that the syntax has changed and both are correct in different places, and the other is rejected there. I wonder why clang 18 is ending up on this branch for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clang 18 rejects operator"" _a
2 participants