Do *not* export namespace detail
#2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
May 14, 2021
include/fmt/chrono.h
Outdated
Comment on lines
459
to
460
| FMT_MODULE_EXPORT_END | ||
| namespace detail { |
There was a problem hiding this comment.
I suggest adding FMT_BEGIN_DETAIL_NAMESPACE / FMT_END_DETAIL_NAMESPACE macros to avoid repeating this sequence throughout the code.
There was a problem hiding this comment.
Makes sense. I will apply this suggestion in all of fmt/include where applicable.
Introduce `FMT_BEGIN_DETAIL_NAMESPACE` and `FMT_END_DETAIL_NAMESPACE` for `namespace detail` sections embedded in that part of the code that contains all declarations that are exported from the module, i.e. which is enclosed by `FMT_MODULE_EXPORT_BEGIN` and `FMT_MODULE_EXPORT_END`. Given a correct implementation of C++20 modules, neither the name `fmt::detail` nor any of its contents will become visible outside of the module.
DanielaE
force-pushed
the
fix/exported-detail-namespace
branch
from
e7885e1
to
f983677
Compare
|
All headers included in the module have at most one single |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.