Simplify CompileTimeFormattingTest tests by reordering arguments of EXPECT_EQ #2044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #2019 by simplifying tests. This change was requested there #2019 (comment) but I didn't manage to simplify it.
Turns out that the position in
EXPECT_EQ
macro is the key:In this PR arguments are just swapped, so the result is the first argument. Just like all over the file:
fmt/test/compile-test.cc
Lines 125 to 136 in 5a49356