Fixing installation directory of '*.dll' files on Windows #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Dec 1, 2019
Comment on lines
+222
to
+223
| set(FMT_BIN_DIR ${CMAKE_INSTALL_BINDIR} CACHE STRING | ||
| "Installation directory for libraries, relative to ${CMAKE_INSTALL_PREFIX}.") |
There was a problem hiding this comment.
Does this need to be configurable? I suggest removing this option and just using ${CMAKE_INSTALL_BINDIR}.
There was a problem hiding this comment.
No, this does not need to be configurable. I just copied what was there for ${FMT_LIB_DIR}.
|
Merged without the new option in 159f89e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.