-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapted to biicode via biicode.conf, ignore.bii and CMakeLists.txt #104
Conversation
Thanks for the PR. Unfortunately the Travis build fails on OS X https://travis-ci.org/cppformat/cppformat/jobs/50072282, because it doesn't have |
I'll fix the OSX Travis building, and update the PR |
fa8ac90
to
7433e78
Compare
Thanks. BTW I recommend moving any nontrivial logic to a separate (Python) script as it is done here: https://github.com/ampl/mp/blob/master/.travis.yml & https://github.com/ampl/mp/blob/master/support/travis-build.py, because Travis config is not great for embedding scripts with logic (unless I'm missing something). |
7433e78
to
fea7991
Compare
I just updated it ;) |
I'm working on separating it like you said :) I'll try to update it today Cheers, |
Thanks, Fran. |
1fc5916
to
2352187
Compare
I just separated Travis build support for biicode in a I hope it fits. |
Looks good, thanks. One minor thing: is it possible to move Biicode-related files |
For now, it's no possible :( |
OK, this is not very important. I just wanted to check if it is possible to keep the top-level directory less cluttered. Looking at the diff https://github.com/cppformat/cppformat/pull/104/files#diff-354f30a63fb0907d4ad57269548329e3R24 I don't quite understand why change the permission every time:
I think it would be better to set the executable permission on the file in Git and get rid of this command. |
2352187
to
28de03c
Compare
…ixed Travis (original and biicode building)
28de03c
to
7b77eb6
Compare
I just fixed it ;) |
Adapted to biicode via biicode.conf, ignore.bii and CMakeLists.txt
Merged, thanks! |
@franramirez688 BTW I tried to publish the repo to biicode as you suggested by adding
and executing
but I get an error:
Am I missing something? |
Ok, when you clone this repo to your PC, it isn't a biicode project yet, so you only have to follow these simple steps:
Checkout the github repository in block folder:
We're working on a new command to change these steps to more easier ones ;) |
If you want, I can add to the |
Thanks for the clarification, now I see how it works. Just published the updated version on Biicode.
That would be awesome. |
Ok, so my next PR will bring it ;) |
Thanks. |
It's a full adaptation of cppformat to biicode. Travis has mixed building with and without biicode at same compilation time to keep your library free of bugs in both building systems.
If you want to publish the repo to biicode directly when you make any modification, add to your
biicode.conf
the parent, e.g.:and execute:
to publish the block as DEV in vitaut/cppformat
I just added a folder named biicode/ with cmake/ and samples/ subfolders to make possible this adaptation and .travis.yml can build an executable with biicode