Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC warning C4365 with /Wall and FMT_STRING() #2233

Closed
vid512 opened this issue Apr 13, 2021 · 4 comments
Closed

MSVC warning C4365 with /Wall and FMT_STRING() #2233

vid512 opened this issue Apr 13, 2021 · 4 comments

Comments

@vid512
Copy link

vid512 commented Apr 13, 2021

Any FMT_STRING() usage causes a warning C4365 (un/signed mismatch), when compiling with MSVC (14.28.29910, from Visual Studio 2019) with /Wall:

#include <fmt/format.h>
void test() {
	fmt::format(FMT_STRING("a"));
}

Note: despite being displayed as warning C4365, this particular warning cannot be enabled with just #pragma warning(default:4365). You must use /Wall to trigger it. It also can't be disabled by /Wall /wd4365.

@vid512
Copy link
Author

vid512 commented Apr 13, 2021

CMake build log.txt

@vitaut
Copy link
Contributor

vitaut commented Apr 14, 2021

Which {fmt} version?

@vid512
Copy link
Author

vid512 commented Apr 14, 2021

version 7.1.3

vitaut added a commit that referenced this issue Apr 16, 2021
vitaut added a commit that referenced this issue Apr 16, 2021
@vitaut
Copy link
Contributor

vitaut commented Apr 16, 2021

Fixed in 6271406.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants