Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferedFileTest.Fileno sometimes take a very long time. #2196

Closed
edge90 opened this issue Mar 29, 2021 · 1 comment
Closed

BufferedFileTest.Fileno sometimes take a very long time. #2196

edge90 opened this issue Mar 29, 2021 · 1 comment

Comments

@edge90
Copy link

edge90 commented Mar 29, 2021 

15: [WARNING] fmt-7.1.3/test/gmock-gtest-all.cc:7179:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads.
15: [       OK ] BufferedFileTest.Fileno (300168 ms)
15: [----------] 12 tests from BufferedFileTest (300168 ms total)

Linux hostname 4.18.0-193.14.3.el8_2.x86_64 #1 SMP Mon Jul 20 15:02:29 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
gcc 10
vitaut added a commit that referenced this issue Mar 30, 2021
@vitaut
Don't call fileno on NULL file in tests (#2196)
afe23e7
@vitaut
Copy link
Contributor

vitaut commented Mar 30, 2021

This test is quite problematic because some implementations don't check if the file pointer is null. I removed it since it's covered by posix-mock-tests anyway. Thanks for reporting.

@vitaut vitaut closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @edge90