-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalized wavelength extraction & fix xy mixup in ROI tables #36
Generalized wavelength extraction & fix xy mixup in ROI tables #36
Conversation
We just realized that our generalized handling of the Intensity metadata was now working insofar as processing wouldn't crash when different names are given to the Intensity metadata. But on the ZMB side, the data was still not correctly added to the OME-Zarr metadata yet. To achieve that, we also had to generalize which Intensity metadata is read in in the |
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 93.76% 96.05% +2.29%
==========================================
Files 16 16
Lines 1315 1293 -22
==========================================
+ Hits 1233 1242 +9
+ Misses 82 51 -31
|
Quick overview of this PR: Both metadata changes are to make sure the parser works for MDs with differently named intensity channels (like the one at ZMB). Metadata change 1 in MetaSeriesUtils: Metadata change 2 in MetaSeriesTiff: Change to ROI tables: This PR is work together with @fstur |
14355d1
to
1461e91
Compare
I rebased onto current |
This addresses #35
I based it on the #32 branch, as I'm working from that. If necessary, I can also rebase to the current main. But I'd suggest we merge this after #32.
=> only the last commit, 02652b9, is new.
This reads out any metadata entry that ends in "Intensity", which just appear to be the ones we're interested in and works both for FMI setups & ZMB setups. The metadata doesn't contain a list of wavelengths or a similar entry we could use to get the definitive list of channels.
For backwards compatibility, I included an optional renaming of the wavelengths to the strings used before. For the more general case, I'd suggest we go with whatever string the microscope metadata provides.